Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Merge pull request #10069 from Turbo87/publish-stream" #10166

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 9, 2024

This reverts commit 4f55cbe.

The AWS team has investigated and fixed the Cloudfront issue that led to early responses being converted to HTTP 5xx errors on their side, so this refactoring can be applied again :)

Related:

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (0aea38a) to head (6e71d80).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/krate/publish.rs 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10166      +/-   ##
==========================================
- Coverage   89.57%   89.57%   -0.01%     
==========================================
  Files         295      295              
  Lines       31690    31720      +30     
==========================================
+ Hits        28386    28412      +26     
- Misses       3304     3308       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 6f81f3d into rust-lang:main Dec 10, 2024
10 checks passed
@Turbo87 Turbo87 deleted the early-publish-errors branch December 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant