Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #135089

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Update cargo #135089

merged 1 commit into from
Jan 4, 2025

Conversation

weihanglo
Copy link
Member

9 commits in d73d2caf9e41a39daf2a8d6ce60ec80bf354d2a7..fd784878cfa843e3e29a6654ecf564c62fae6735
2024-12-31 20:51:21 +0000 to 2025-01-03 20:06:26 +0000

@weihanglo weihanglo self-assigned this Jan 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2025
@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Jan 3, 2025

📌 Commit 20a44e6 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025
@bors
Copy link
Contributor

bors commented Jan 4, 2025

⌛ Testing commit 20a44e6 with merge d13c80a...

@bors
Copy link
Contributor

bors commented Jan 4, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing d13c80a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2025
@bors bors merged commit d13c80a into rust-lang:master Jan 4, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
@weihanglo weihanglo deleted the update-cargo branch January 4, 2025 04:42
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d13c80a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
-0.1% [-0.2%, -0.1%] 38
Improvements ✅
(secondary)
-0.3% [-0.6%, -0.1%] 35
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 38

Max RSS (memory usage)

Results (primary -1.1%, secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
-3.2% [-3.3%, -3.2%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-3.3%, 3.0%] 3

Cycles

Results (primary 3.0%, secondary 3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [0.7%, 4.5%] 3
Regressions ❌
(secondary)
3.5% [1.7%, 8.0%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.0% [0.7%, 4.5%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.063s -> 764.09s (0.27%)
Artifact size: 325.54 MiB -> 325.72 MiB (0.05%)

@rustbot rustbot added the perf-regression Performance regression. label Jan 4, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Jan 7, 2025

Almost all green with just a tiny regression, and this is a cargo update anyway, so not that much we can do.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants