-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Windows, fix undecorated shadow reported client size is bigger than what's visible #3712
base: master
Are you sure you want to change the base?
On Windows, fix undecorated shadow reported client size is bigger than what's visible #3712
Conversation
6d8873e
to
4caf694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to reproduce this? Using the base example on the master
branch, I don't see this on Windows 11.
(Looks good otherwise)
I have added an example in this PR that can be used to test this, just checkout this PR and revert the changes made to I am also using Windows 11, the issue seems to happen only when undecorated shadows are active. |
@notgull this should be ready now, thanks to implementation of the folks at GPUI, I tested different combination of decorations and undecorated shadows and all work as expected. I tested the implementation with winit and wry as well. I have included an example in this PR that creates a window with a border on the reported surface size which can be used to compare with master branch. |
This PR also has a good side effect that makes undecorated windows with shadows have native resize handles without explicitly handling Undecorated windows with shadows are unaffected, would still need manual hittesting. |
changelog
module if knowledge of this change could be valuable to usersHere is before:
![image](https://private-user-images.githubusercontent.com/48618675/334256014-c738bb4b-0bec-465f-ae74-8f8939ba2c81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODQ3MzEsIm5iZiI6MTczOTM4NDQzMSwicGF0aCI6Ii80ODYxODY3NS8zMzQyNTYwMTQtYzczOGJiNGItMGJlYy00NjVmLWFlNzQtOGY4OTM5YmEyYzgxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE4MjAzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzMTc5MWEwMzFhYmUxMDUxNjgxNDBjMTAxNWU0NTdkZTdlNjk0ZDg4YTU0NTVhZTVkZGJmNGExZjliYTMwM2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FENZqq1wwl8nJIdJR6_6-BNHHH0WQoyi7zjG5GXpuLc)
And here is after:
![image](https://private-user-images.githubusercontent.com/48618675/334255872-250125a6-31fe-451c-8833-a94845bf1d0f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODQ3MzEsIm5iZiI6MTczOTM4NDQzMSwicGF0aCI6Ii80ODYxODY3NS8zMzQyNTU4NzItMjUwMTI1YTYtMzFmZS00NTFjLTg4MzMtYTk0ODQ1YmYxZDBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE4MjAzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkYThmMGJjNjcyMzE0NDEwNWMwZGYxMWU3ZjQ0MDkzMGEyMDI4NmZiYmQ0YjM0YjkxYzdkMTBjMmQyMTllMTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iE9koWHg5dEQ93kYNoq2eX7ouLyvqv7uBg0pOfYFO1g)