Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcgen: 0.13.1 -> 0.13.2 #303

Merged
merged 1 commit into from
Dec 19, 2024
Merged

rcgen: 0.13.1 -> 0.13.2 #303

merged 1 commit into from
Dec 19, 2024

Conversation

lvkv
Copy link
Contributor

@lvkv lvkv commented Dec 19, 2024

Coming from #285 (comment). @djc did you want me to write the changelog as well? Don't want to step on your toes.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@est31
Copy link
Member

est31 commented Dec 19, 2024

A changelog would be nice, otherwise LGTM

@djc djc added this pull request to the merge queue Dec 19, 2024
@djc
Copy link
Member

djc commented Dec 19, 2024

I'll generate a changelog when I publish.

Merged via the queue into rustls:main with commit 447322c Dec 19, 2024
15 checks passed
@djc
Copy link
Member

djc commented Dec 20, 2024

@est31 so all the other rustls projects use GitHub releases and their generated changelogs instead of a manually curated CHANGELOG.md. I forget how much we have discussed this before, but would you be open to using that? We would pull out manually written high-level release notes for anything of particular interest to users. I would be willing to convert the old CHANGELOG.md contents into GitHub releases if that helps.

@est31
Copy link
Member

est31 commented Dec 20, 2024

Personally I'm not a fan of only doing github releases. they are useful for attaching downloadable build artifacts and advertise the release on github, but they are github proprietary, are paginated on a very small scale, and you need network access to access them. CHANGELOG.md on the other hand sits in any clone of the repository and gets shipped to users via cargo vendor.

Doing both has some advantages, but if it is you who are writing the changelogs then I don't want to tell you what to do. Maybe we keep CHANGELOG.md and say that any newer release can be found on github releases?

@djc
Copy link
Member

djc commented Dec 20, 2024

Doing both has some advantages, but if it is you who are writing the changelogs then I don't want to tell you what to do. Maybe we keep CHANGELOG.md and say that any newer release can be found on github releases?

Will do, thanks!

@djc
Copy link
Member

djc commented Dec 20, 2024

  • Published rcgen v0.13.2 at registry crates-io
  • [new tag] v0.13.2 -> v0.13.2
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants