-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disable dependabot cargo updates #120
Conversation
Did you want to discuss that in this PR or would it be better to open a followup issue where the topic can happen? I don't mind either way. |
WFM! I think there's two topics:
|
I generally scroll through the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also disable this for github-actions
?
A potential third topic for discussion: being more explicit about ownership. So far I think we've mostly deferred to @complexspaces on any half-way nuanced changes, but the downside is that @complexspaces has pretty limited bandwidth certainly compared to the other rustls org maintainers. Maybe we can get to a tweaked proposed governance model? |
These seem infrequent enough that I was OK leaving it on, but happy to revisit. |
Hey folks, @complexspaces directly reports to me currently (I'm director of seceng at 1Password); I don't feel particularly strongly one way or another as to what the governance model of this library/project should look like, but I am open to discussion as to how/where we can adjust or increase 1Password involvement/support. :) Let's bring this discussion into another issue? |
Opened #125 for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also disable this for github-actions?
These seem infrequent enough that I was OK leaving it on, but happy to revisit.
I'm also in favor of leaving GHA updates enabled since they are less frequent and less work to review.
I generally scroll through the Cargo.lock changes looking for any new dependencies, but I don't look at the actual changes made in semver-compatible upstream versions.
This is what I do as well.
Overall, I'm in favor of what is currently being proposed in this PR's branch contents as it creates less noise and review burden over very small changesets.
Until we have a better sense of how to handle the update PRs it produces let's turn this off for now. I think I was premature in enabling it.
1855a77
to
ce4abed
Compare
Until we have a better sense of how to handle the update PRs it produces let's turn this off for now. I think I was premature in enabling it. Inspired by discussion in this PR thread.