Cargo: remove rcgen git patch #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rcgen` crate has cut a 0.11.2 release that includes the CRL functionality we were using a Cargo patch to depend on previously. This commit removes the patch and updates the `Cargo.toml` file. We temporarily include the "pem" feature to avoid a build breakage introduced in 0.11.2 yet to be fixed upstream.
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 96.50% 96.50%
=======================================
Files 19 19
Lines 4466 4466
=======================================
Hits 4310 4310
Misses 156 156 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rcgencrate has cut a 0.11.2 release that includes the CRL functionality we were using a Cargo patch to depend on previously. This commit removes the patch, fixes a breakage in the CRL benchmark, and updates theCargo.tomlfile.We temporarily include the "pem" feature to avoid a build breakage introduced in 0.11.2 yet to be fixed upstream (rustls/rcgen#161).