Skip to content

Commit

Permalink
Revert "lenses/fstab.aug: Allow comma after the last option (hercules…
Browse files Browse the repository at this point in the history
…-team#838)"

A more general fix will follow.

This reverts commit 5246ef0.

Signed-off-by: Richard W.M. Jones <[email protected]>
  • Loading branch information
rwmjones committed Feb 4, 2025
1 parent cd37b09 commit 34442c5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
3 changes: 1 addition & 2 deletions lenses/fstab.aug
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ module Fstab =

let sep_tab = Sep.tab
let sep_spc = Sep.space
let sep_comma_tab = del /,?[ \t]+/ "\t"
let comma = Sep.comma
let eol = Util.eol

Expand All @@ -29,7 +28,7 @@ module Fstab =
[ label "file" . store file ] . sep_tab .
comma_sep_list "vfstype" .
(sep_tab . comma_sep_list "opt" .
(sep_comma_tab . [ label "dump" . store /[0-9]+/ ] .
(sep_tab . [ label "dump" . store /[0-9]+/ ] .
( sep_spc . [ label "passno" . store /[0-9]+/ ])? )? )?
. Util.comment_or_eol ]

Expand Down
11 changes: 0 additions & 11 deletions lenses/tests/test_fstab.aug
Original file line number Diff line number Diff line change
Expand Up @@ -156,17 +156,6 @@ module Test_fstab =
{ "#comment" = "device at install: /dev/sda3" }
}

(* Bug #832 - Allow comma after the last option *)
test Fstab.lns get "/dev/mapper/foo-bar / xfs defaults, 0 0\n" =
{ "1"
{ "spec" = "/dev/mapper/foo-bar" }
{ "file" = "/" }
{ "vfstype" = "xfs" }
{ "opt" = "defaults" }
{ "dump" = "0" }
{ "passno" = "0" }
}

(* Local Variables: *)
(* mode: caml *)
(* End: *)

0 comments on commit 34442c5

Please sign in to comment.