This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
added support for mongoid #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
| end | ||
|
|
||
| if defined?(Mongoid::Document) | ||
| Mongoid::Document::ClassMethods.send(:include, Xapit::Client::Membership::ClassMethods) |
There was a problem hiding this comment.
this can be moved to the initializer? (https://github.com/ryanb/xapit/blob/master/lib/xapit/client/railtie.rb#L9-11)
There was a problem hiding this comment.
why? I want those methods available on sinatra too, that's not rails exclusive
There was a problem hiding this comment.
sounds good, then is a good idea move the AR one to active_record_adapter.rb
There was a problem hiding this comment.
then is a good idea move the AR one to the adapter also :)
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: Jorge H. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
Signed-off-by: David A. Cuadrado <[email protected]>
… slow Signed-off-by: David A. Cuadrado <[email protected]>
Conflicts: lib/xapit.rb xapit.gemspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please let me know if you need something else