Skip to content

Commit

Permalink
Make APIClient.list_domains return all domain metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
s-hamann committed Jun 8, 2024
1 parent 6d50403 commit 7384d79
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions desec.py
Original file line number Diff line number Diff line change
Expand Up @@ -866,13 +866,14 @@ def delete_token_policy(self, token_id: str, policy_id: str) -> None:
url = f"{API_BASE_URL}/auth/tokens/{token_id}/policies/rrsets/{policy_id}/"
_ = self.query("DELETE", url)

def list_domains(self) -> list[str]:
def list_domains(self) -> list[JsonDomainType]:
"""Return a list of all registered domains.
See https://desec.readthedocs.io/en/latest/dns/domains.html#listing-domains
Returns:
A list of all registered domain names for the current account.
A list of all registered domains for the current account, including basic
metadata.
Raises:
AuthenticationError: The token used for authentication is invalid.
Expand All @@ -881,7 +882,7 @@ def list_domains(self) -> list[str]:
"""
url = f"{API_BASE_URL}/domains/"
data = self.query("GET", url)
return [domain["name"] for domain in t.cast(list[JsonDomainType], data)]
return t.cast(list[JsonDomainType], data)

def domain_info(self, domain: str) -> JsonDomainWithKeysType:
"""Return basic information about a domain.
Expand Down Expand Up @@ -1974,7 +1975,7 @@ def main() -> None:
elif arguments.action == "list-domains":
domains_result = api_client.list_domains()
for d in domains_result:
print(d)
print(d["name"])

elif arguments.action == "domain-info":
domain_result = api_client.domain_info(arguments.domain)
Expand Down

0 comments on commit 7384d79

Please sign in to comment.