Merge pull request #31 from sagarkhanal07/refactor/conventional-commits

sagarkhanal07 · Sep 12, 2023 · a8f2332 · a8f2332
2 parents 5d27710 + 581e295
commit a8f2332
Show file tree

Hide file tree

Showing 8 changed files with 711 additions and 97 deletions.
diff --git a/.husky/commit-msg b/.husky/commit-msg
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+yarn commitlint ${1}
diff --git a/App.tsx b/App.tsx
diff --git a/README.md b/README.md
@@ -8,14 +8,13 @@ This project is highly inspired by [next-enterprise](https://github.com/Blazity/
 - [x] 🎯 Absolute imports - For better imports and code organization
 - [x] 📝 Conventional commits git hook - For enforcing conventional commits
 - [x] 🤖 Renovate BOT - For keeping dependencies up to date
-- [x] 🛠️ Extremely strict TypeScript - With ts-reset library for ultimate type safety
+- [x] 🛠️ Improved TypeScript - With ts-reset library for ultimate type safety
 - [x] 🩹 Patch-package - For patching dependencies
 - [x] 💻 T3 Env - For environment variables management
 - [x] 📊 Bundle analyzer plugin - For analyzing bundle size
 - [ ] 🧪 Jest and React Testing Library - For testing components and features
 - [x] 📕 Storybook - For isolating and testing UI components
 - [x] 📈 Components coupling and cohesion graph - For analyzing components relations
-- [ ] 🚀 GitHub Actions - For CI/CD automation
 - [x] 🤖🧠 Automated ChatGPT Code Reviews - For improving code quality and AI assistance code reviews
 - [ ] 🚢 Semantic Release - For automated versioning and CHANGELOG generation
 - [x] 🗄️ Auto Sort Imports - Automatic organizing of imports on file saves.
@@ -37,7 +36,7 @@ Preconfigured by default.
 
 ### Conventional Commits
 
-Configured with [git-conventioanl-commits](https://github.com/qoomon/git-conventional-commits) to automatically validate commit messages following the [conventional-commits](https://www.conventionalcommits.org/en/v1.0.0/) standard.
+Configured with [commitlint](https://github.com/conventional-changelog/commitlint) to automatically validate commit messages following the [conventional-commits](https://www.conventionalcommits.org/en/v1.0.0/) standard.
 
 ### TS-Reset | Extremely Strict Typescript
 

diff --git a/commitlint.config.js b/commitlint.config.js
@@ -0,0 +1 @@
+module.exports = { extends: ['@commitlint/config-conventional'] };
diff --git a/git-conventional-commits.yaml b/git-conventional-commits.yaml
diff --git a/package.json b/package.json
@@ -12,10 +12,11 @@
     "lint:fix": "eslint --fix .",
     "format": "prettier --write .",
     "analyze:bundle": "react-native-bundle-visualizer --only-mapped --entry-file ./index.js --bundle-output ./rn.bundle --expo",
-    "coupling-graph": "npx skott index.js",
+    "coupling-graph": "npx skott src/pages/HomePage.tsx",
     "prepare": "husky install",
     "storybook-generate": "sb-rn-get-stories",
-    "storybook-watch": "sb-rn-watcher"
+    "storybook-watch": "sb-rn-watcher",
+    "commitlint": "commitlint --edit"
   },
   "dependencies": {
     "@t3-oss/env-core": "^0.6.1",
@@ -27,6 +28,8 @@
   },
   "devDependencies": {
     "@babel/core": "^7.20.0",
+    "@commitlint/cli": "^17.7.1",
+    "@commitlint/config-conventional": "^17.7.0",
     "@react-native-async-storage/async-storage": "1.18.2",
     "@react-native-community/datetimepicker": "7.2.0",
     "@react-native-community/slider": "4.4.2",

diff --git a/src/components/Button/index.tsx b/src/components/Button/index.tsx
@@ -15,7 +15,7 @@ export const Button = ({ onPress, text, type = 'default' }: ButtonProps) => {
   const color = type === 'default' ? 'white' : 'black';
   return (
     <TouchableOpacity
-      style={type === 'default' ? styles.default : styles.transparent}
+      style={styles[type]}
       onPress={onPress}
       activeOpacity={0.8}
     >
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		module.exports = { extends: ['@commitlint/config-conventional'] };