Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: embed polyfill for blob and file #428

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Nov 13, 2023

This is a kind of better blob implementation cuz it can references other blobs and dose not have to hold all data in memory.
it's a way better implementation for later being able to create blob's that are backed up by the disk.

it mostly comes from fetch-blob with some minor adjustments

@saghul
Copy link
Owner

saghul commented Nov 13, 2023

Thank you! Can you regenerate the C file please?

@jimmywarting
Copy link
Contributor Author

Plz Tell me how. This is my first contribution.

@saghul
Copy link
Owner

saghul commented Nov 13, 2023

Ssure, just run make js

@jimmywarting
Copy link
Contributor Author

Thx, Done!

@saghul
Copy link
Owner

saghul commented Nov 13, 2023

Looks like a test is failing, can you check?

@jimmywarting
Copy link
Contributor Author

jimmywarting commented Nov 13, 2023

A blob where constructed with invalid arguments in test-ws-send.js:13

- new Blob(arrayBuffer)
+ new Blob([ arrayBuffer ])

@saghul saghul merged commit 0551d36 into saghul:master Nov 14, 2023
11 checks passed
@saghul
Copy link
Owner

saghul commented Nov 14, 2023

Thanks a lot!

@jimmywarting jimmywarting deleted the files branch November 14, 2023 21:13
@saghul
Copy link
Owner

saghul commented Nov 25, 2023

I was thinking about using your FormData libary to polyfill FormData, what do you think?

@jimmywarting
Copy link
Contributor Author

Sure. Feel free to copy as much or as little as you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants