Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contextHelper.ts #6

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

anitarodia
Copy link

Source priority fix

Source priority fix
@fernando-delosrios-sp
Copy link
Collaborator

Hi Animesh,

Thanks for the PR. I was checking the code and it beats me why we would need to sort the authoritative sources when there's a dedicated function, listSourceAccounts, that iterates through the source list from the config before processing attributes. Authoritative accounts come from a joint query including all configured sources. I'd like to better understand where the error in my logic is.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants