Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add languages support #264

Merged
merged 52 commits into from
Sep 2, 2021
Merged

add languages support #264

merged 52 commits into from
Sep 2, 2021

Conversation

saleem-hadad
Copy link
Owner

@saleem-hadad saleem-hadad commented Mar 30, 2021

#58 and #252

Current approach
[WIP]

Proposed approach
Untitled Diagram

Open discussion and tech discovery:

  1. I've tried to implement the decorator pattern around caching and actual implementation. However, I think this might be a bit difficult and might introduce buggy behaviour when extending/replacing the core file fetching functionality. Therefore, I'm considering cache as a separate extendable/replaceable layer without interfering with the core logic of fetching from the file system.
  2. The proposed approach allows source agnostic (i.e replacing file system with DB in a separate package for example)

Breaking changes:

extracted packages

  • LaRecipeTracking
  • LaRecipeSearch

@saleem-hadad saleem-hadad added the enhancement New feature or request label Mar 30, 2021
@saleem-hadad saleem-hadad mentioned this pull request Sep 2, 2021
@saleem-hadad saleem-hadad marked this pull request as ready for review September 2, 2021 19:48
@saleem-hadad saleem-hadad merged commit 699d468 into 3.x Sep 2, 2021
@saleem-hadad saleem-hadad deleted the feature-lanauges branch September 2, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant