Skip to content

Commit

Permalink
stop cp refresh until perf issue fixed (#146)
Browse files Browse the repository at this point in the history
  • Loading branch information
plaird authored Jun 30, 2020
1 parent 17edc08 commit f836416
Showing 1 changed file with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ protected IProject[] build(int kind, Map<String, String> args, IProgressMonitor
WorkProgressMonitor progressMonitor = new EclipseWorkProgressMonitor(monitor);
IProject project = getProject();
progressMonitor.beginTask("Bazel build", 1);


// TODO there is something seriously wrong with Eclipse's resource change mechanism
// To be fixed in https://github.com/salesforce/bazel-eclipse/issues/145
// We are getting FULL_BUILD commands even if files have not changed.
// See also the commented out line below for refreshProjectClasspath
//System.out.println(">> Eclipse signaled that project ["+project.getName()+"] is dirty with kind ["+kind+"]");

BazelCommandManager bazelCommandManager = BazelPluginActivator.getBazelCommandManager();
JavaCoreHelper javaCoreHelper = BazelPluginActivator.getJavaCoreHelper();
BazelWorkspace bazelWorkspace = BazelPluginActivator.getBazelWorkspace();
Expand All @@ -114,7 +120,8 @@ protected IProject[] build(int kind, Map<String, String> args, IProgressMonitor
Set<IProject> downstreamProjects = getDownstreamProjectsOf(project, allImportedProjects);
buildProjects(bazelWorkspaceCmdRunner, downstreamProjects, progressMonitor, rootWorkspaceProject, monitor);

refreshProjectClasspath(project, progressMonitor, monitor, bazelWorkspaceCmdRunner);
// TODO this is too slow, we need to fix this in https://github.com/salesforce/bazel-eclipse/issues/145
//refreshProjectClasspath(project, progressMonitor, monitor, bazelWorkspaceCmdRunner);
}
} catch (BazelCommandLineToolConfigurationException e) {
LOG.error("Bazel not found: {} ", e.getMessage());
Expand Down

0 comments on commit f836416

Please sign in to comment.