sendPrivate for long help and logging messages #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivate message when they ask Hubot for help.
…th 'what did i miss' commands. Replaced send with sendPrivate everywhere the ineffective direct_user helper gets used.
|
Here's the pull request for hubot-irc to add the sendPrivate method nandub/hubot-irc#118 |
|
what a coincidence. Thanks. |
sambao21
added a commit
that referenced
this pull request
Apr 9, 2014
sendPrivate for long help and logging messages
|
from the logs 2014-04-09T12:22:34.581503+00:00 app[web.1]: [Wed Apr 09 2014 12:22:34 GMT+0000 (UTC)] ERROR [TypeError: Object # has no method 'sendPrivate'] |
|
help does work though, so it's pulling hubot-irc 0.2.2 correctly, but that's also interfacing on the response |
|
had to do this 1216c55 eliminates error, but now it shows so something still not right |
|
this was the fix 4d30530 working now...no more flooding |
|
Thanks for the quick merge and fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested my changes to logger.coffee; I am new to IRC and not sure how to set up a test channel. The change seems pretty straightforward, though.
The sendPrivate method was added literally yesterday. That's what I call timing!