Minor frontend pr draft #795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todos - make sidebar react to new minors, conditional rendering - make add plan / edit plan modal support adding / edit minors - also needs to be implemented for localstorage
TODO MAKE CURRENT MINOR SHOW UP IN EDIT DROPDOWN
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KobeZ123
requested changes
Jan 22, 2025
| @@ -29,13 +29,16 @@ import { useForm } from "react-hook-form"; | |||
| import { mutate } from "swr"; | |||
| import { | |||
| useSupportedMajors, | |||
| //useSupportedMinors, | |||
| @@ -173,6 +185,9 @@ export class OnboardStudentDto { | |||
| @IsString() | |||
| major: string; | |||
|
|
|||
| @IsString() | |||
| minor: string; | |||
There was a problem hiding this comment.
should this be optional too?
| if (supportedMinorsError) { | ||
| handleApiClientError(supportedMinorsError, router); | ||
| } | ||
| //if (supportedMinorsError) { |
| return Object.keys(minorMap ?? {}) | ||
| .map((minorName) => { | ||
| return { | ||
| //label: (minorMap?.[minorName].verified ? "" : "[BETA] ") + majorName, |
There was a problem hiding this comment.
let's encode the label check in
* adding business parsed JSON * bringing back all majors with business in name * remove mathematics test minor
updated array of catalog years
Update index.ts
Modal Error Component + Co-op in first/last semester bug
todos - make sidebar react to new minors, conditional rendering - make add plan / edit plan modal support adding / edit minors - also needs to be implemented for localstorage
TODO MAKE CURRENT MINOR SHOW UP IN EDIT DROPDOWN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor frontend support.
Closes # (issue number)
Type of change
Please tick the boxes that best match your changes.
yarn installyarn dev:migration:runHow Has This Been Tested?
Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.
Checklist: