updated addplan modal to support empty plan name #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit f9a10e9.
KobeZ123
approved these changes
Feb 19, 2025
| @@ -60,6 +60,13 @@ export const AddPlanModal: React.FC<AddPlanModalProps> = ({ | |||
| const { onOpen, onClose: onCloseDisplay, isOpen } = useDisclosure(); | |||
| const { supportedMajorsData, error: supportedMajorsError } = | |||
| useSupportedMajors(); | |||
|
|
|||
| // Generate default plan title using formatted date and time | |||
| const generateDefaultPlanTitle = () => { | |||
There was a problem hiding this comment.
can we make this "Plan for [insert major name here]" instead? we can also ask designers about how the interaction should be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated form validation. Title is no longer required. This is because the value is set to
Plan [timestamp]if value is empty.Plan [timestamp]is also placeholder value for plan. Hopefully not too expensive to get timestamp.EDIT 2/18: Added catalog year + major name to the default name. kept date and time to prevent repeated names. not sure if necessary.
EDIT 2/18 (1): went back to og, with timestamp, this is because if we type their major for them the title might be too long
Closes #789
Type of change
Please tick the boxes that best match your changes.
yarn installyarn dev:migration:runChecklist: