#141 task template stages visibility successfully toggles. #144
Conversation
There was a problem hiding this comment.
testing + code LGTM! Only thing is I would suggest we do more graceful error handling in a comment I put down below because there is nothing the user can really do if the toggle is NOT on/off, also I'm thinking since it's going to be a toggle it has to be on/off only.
| stageId: string, | ||
| visibility: string | ||
| ): APIResponse<IBattery> => { | ||
| if (visibility !== "on" && visibility !== "off") { |
There was a problem hiding this comment.
my only thought with this is that the visibility must be on or off, so perhaps if there is some more graceful error handling or we just default to off that might be better than throwing an error
There was a problem hiding this comment.
What if we simply remove the check? That way, our logic would dictate that visibilityBool is true if visibility is "on", and if it's anything else, it simply defaults to false. This would include the case where the caller of the API states the visibility to be "off".
Adds visibility to IBatteryStage Schema. Created an endpoint to update the field based on the given status (on = true off = false). Now, visibility of task template stages can be toggled using the /admin/battery//stage//visibility/ path.
If the battery/stage is not found, a 404 error is thrown.
Tested using Postman/MongoDB instances. Tested turning the visibility on and off for a specific stage.