Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electron #99

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add electron #99

wants to merge 4 commits into from

Conversation

ross3102
Copy link
Collaborator

@ross3102 ross3102 commented Feb 6, 2024 •
edited
Loading

  • Add electron via capacitor
  • Add electron build to pnpm build script
  • Create separate scripts pnpm build:dev to build with dev params and pnpm dev:electron to run electron locally
  • Allow API to be run in secure mode (required by electron for cross-origin cookie policy reasons)

Note: files in electron directory are mostly auto-generated

Closes #17

@ross3102 ross3102 requested a review from DavidOB1 February 6, 2024 05:08
DavidOB1
DavidOB1 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@DavidOB1 DavidOB1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-config code looks pretty standard so I'm approving for now but before merging we should make sure this runs correctly on other peoples' machines and add instructions if further steps are needed.

packages/ui/electron/package.json
{
"name": "Brain Game Center",
"version": "1.0.0",
"description": "An Amazing Capacitor App",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes so hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidOB1 DavidOB1 DavidOB1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add electron
2 participants
@ross3102 @DavidOB1