FEATURE: WIP state of Neos 9 compatibility #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Architecture like ContentRepository.Core; NOT reusing any of Flowpack.Elasticsearch or Flowpack.Elasticsearch.ContentRepositoryAdaptor. I am not sure whether we should re-use Neos.ContentRepository.Search (we'll see).
…earch object instead of passing it through
ahaeslich
reviewed
Sep 11, 2023
Comment on lines
66
to
95
| '_removed': | ||
| search: | ||
| indexing: false | ||
| '_creationDateTime': | ||
| search: | ||
| indexing: false | ||
| '_lastModificationDateTime': | ||
| search: | ||
| indexing: false | ||
| '_lastPublicationDateTime': | ||
| search: | ||
| indexing: false | ||
| '_hiddenBeforeDateTime': | ||
| search: | ||
| indexing: false | ||
| '_hiddenAfterDateTime': | ||
| search: | ||
| indexing: false | ||
| '_path': | ||
| search: | ||
| indexing: false | ||
| '_nodeType': | ||
| search: | ||
| indexing: false | ||
| '_name': | ||
| search: | ||
| indexing: false | ||
| '_hidden': | ||
| search: | ||
| indexing: false |
There was a problem hiding this comment.
These will all throw the exception: The property "PROPERTYNAME" on the subject was not accessible.
| elasticSearchMapping: | ||
| type: date | ||
| format: 'date_time_no_millis' | ||
| indexing: '${(node.hiddenAfterDateTime ? Date.format(node.hiddenAfterDateTime, "Y-m-d\TH:i:sP") : null)}' |
There was a problem hiding this comment.
Are we already supporting hiddenBeforeDateTime and hiddenAfterDateTime? Isn't this feature missing?
Comment on lines
+44
to
+63
| 'neos_last_modification_date_time': | ||
| search: | ||
| elasticSearchMapping: | ||
| type: date | ||
| format: 'date_time_no_millis' | ||
| indexing: '${(node.lastModificationDateTime ? Date.format(node.lastModificationDateTime, "Y-m-d\TH:i:sP") : null)}' | ||
|
|
||
| 'neos_last_publication_date_time': | ||
| search: | ||
| elasticSearchMapping: | ||
| type: date | ||
| format: 'date_time_no_millis' | ||
| indexing: '${(node.lastPublicationDateTime ? Date.format(node.lastPublicationDateTime, "Y-m-d\TH:i:sP") : null)}' | ||
|
|
||
| 'neos_creation_date_time': | ||
| search: | ||
| elasticSearchMapping: | ||
| type: date | ||
| format: 'date_time_no_millis' | ||
| indexing: '${(node.creationDateTime ? Date.format(node.creationDateTime, "Y-m-d\TH:i:sP") : null)}' |
There was a problem hiding this comment.
Those date properties are now located at node.timestamps
BUGFIX: Fix accessing node type name
…raints TASK: Adjust to renamed NodeTypeConstraints
Adjust to Neos 9 beta 11 and add a bit of PHPStan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Architecture like ContentRepository.Core; NOT reusing any of Flowpack.Elasticsearch or Flowpack.Elasticsearch.ContentRepositoryAdaptor.
I am not sure whether we should re-use Neos.ContentRepository.Search (we'll see).