Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise Exception when resetting to same IDD file, just pass #65

Merged
merged 1 commit into from
May 28, 2016

Conversation

pachi
Copy link

@pachi pachi commented Sep 14, 2015

This avoids raising an Exception when resetting the IDD file for the case when the same IDD file is used. It's convenient for using eppy in an IPython Notebook.

@santoshphilip
Copy link
Owner

Pachi,
That is a sweet change.
It really will help with "python notebook" or "ipython" when working interactively with eppy.

I'll merge it in a few days.

Santosh

@pachi
Copy link
Author

pachi commented Sep 14, 2015

Great. I'm preparing some more changes, mainly related to unicode support (i.e. accents in Name fields)

santoshphilip added a commit that referenced this pull request Sep 14, 2015
same IDD file, just pass issue #65
Merge branch 'pachi-iddreimport' into develop
@santoshphilip
Copy link
Owner

I have merged it into the develop branch.
I need to add you to the contributors list on the LICENSE page

Shall I say
Copyright (c) 2015 Rafael Villar Burke

@pachi
Copy link
Author

pachi commented Sep 15, 2015

Yes, that's ok. Thanks!

@santoshphilip
Copy link
Owner

I am going to put in a unit test for this change.
I have discovered the hard way that not writing unit tests bite you hard later :-(

@santoshphilip
Copy link
Owner

why is this issue not appearing on my list of open issues. I see issue #64, but I don't see #65 and #66

@santoshphilip santoshphilip merged commit 8197ee6 into santoshphilip:master May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants