Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend input compatibility to all steam id formats #1002

Closed
wants to merge 1 commit into from

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Nov 9, 2024

Description

The logic used to prevent breaking changes:

  1. Verify the input
  2. Convert it to steam2 format
  3. Continue as normal to prevent massive refactor

Results:

  • Now support all steamid format in search functions
  • Steam3 format can be used with [U:xxx] or directly with U:xxxx

Motivation and Context

#1000

How Has This Been Tested?

In use on https://bans.nide.gg/

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants