Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dockerfile ENV warnings #301

Merged
merged 2 commits into from
Aug 27, 2024
Merged

chore: dockerfile ENV warnings #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5c34a
chore: dockerfile ENV warnings
francisdb Aug 27, 2024
e41ed2d
more cleanup
francisdb Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eclipse-temurin/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ FROM eclipse-temurin:${BASE_IMAGE_TAG:-11.0.16.1_1-jdk}

# Env variables
ARG SCALA_VERSION
ENV SCALA_VERSION ${SCALA_VERSION:-2.13.10}
ENV SCALA_VERSION=${SCALA_VERSION:-2.13.10}
ARG SBT_VERSION
ENV SBT_VERSION ${SBT_VERSION:-1.6.2}
ENV SBT_VERSION=${SBT_VERSION:-1.6.2}
ARG USER_ID
ENV USER_ID ${USER_ID:-1001}
ENV USER_ID=${USER_ID:-1001}
ARG GROUP_ID
ENV GROUP_ID ${GROUP_ID:-1001}
ENV GROUP_ID=${GROUP_ID:-1001}

# Install dependencies
# curl for downloading sbt and scala
Expand Down Expand Up @@ -88,4 +88,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]
4 changes: 2 additions & 2 deletions eclipse-temurin/alpine.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use a multi-stage build to reduce the size of the final image
ARG BASE_IMAGE_TAG
FROM eclipse-temurin:${BASE_IMAGE_TAG:-21.0.2_13-jdk-alpine} as builder
FROM eclipse-temurin:${BASE_IMAGE_TAG:-21.0.2_13-jdk-alpine} AS builder

ARG SCALA_VERSION=3.4.0
ARG SBT_VERSION=1.9.9
Expand Down Expand Up @@ -88,4 +88,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]
12 changes: 6 additions & 6 deletions graalvm-ce/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ FROM ghcr.io/graalvm/graalvm-ce:${BASE_IMAGE_TAG:-java11-21.3.0}

# Env variables
ARG SCALA_VERSION
ENV SCALA_VERSION ${SCALA_VERSION:-2.13.10}
ENV SCALA_VERSION=${SCALA_VERSION:-2.13.10}
ARG SBT_VERSION
ENV SBT_VERSION ${SBT_VERSION:-1.6.2}
ENV JAVA_OPTS -XX:+UseG1GC
ENV SBT_VERSION=${SBT_VERSION:-1.6.2}
ENV JAVA_OPTS=-XX:+UseG1GC
ARG USER_ID
ENV USER_ID ${USER_ID:-1001}
ENV USER_ID=${USER_ID:-1001}
ARG GROUP_ID
ENV GROUP_ID ${GROUP_ID:-1001}
ENV GROUP_ID=${GROUP_ID:-1001}

# Install sbt
RUN \
Expand Down Expand Up @@ -77,4 +77,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]
12 changes: 6 additions & 6 deletions graalvm-community/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ FROM ghcr.io/graalvm/graalvm-community:${BASE_IMAGE_TAG:-21.0.1-ol9}

# Env variables
ARG SCALA_VERSION
ENV SCALA_VERSION ${SCALA_VERSION:-2.13.12}
ENV SCALA_VERSION=${SCALA_VERSION:-2.13.12}
ARG SBT_VERSION
ENV SBT_VERSION ${SBT_VERSION:-1.9.7}
ENV JAVA_OPTS -XX:+UseG1GC
ENV SBT_VERSION=${SBT_VERSION:-1.9.7}
ENV JAVA_OPTS=-XX:+UseG1GC
ARG USER_ID
ENV USER_ID ${USER_ID:-1001}
ENV USER_ID=${USER_ID:-1001}
ARG GROUP_ID
ENV GROUP_ID ${GROUP_ID:-1001}
ENV GROUP_ID=${GROUP_ID:-1001}

# Install sbt
RUN \
Expand Down Expand Up @@ -77,4 +77,4 @@ RUN \
## -w /home/sbtuser
WORKDIR /root

CMD sbt
CMD ["sbt"]