Use sbt-github-actions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
use-sbt-github-actions
branch
from
55eec29 to
588f93c
Compare
mdedetrich
commented
Oct 18, 2024
build.sbt
Outdated
| @@ -1,8 +1,9 @@ | |||
| ThisBuild / organization := Organization.organization | |||
| ThisBuild / organizationName := Organization.organizationName | |||
| ThisBuild / organizationHomepage := Organization.organizationHomepage | |||
| ThisBuild / version := "0.4.0-SNAPSHOT" | |||
| ThisBuild / scalaVersion := "2.12.19" | |||
| val scala212 = "2.12.19" | |||
There was a problem hiding this comment.
This is needed so that sbt-github-actions plays well with the scala versions
mdedetrich
force-pushed
the
use-sbt-github-actions
branch
4 times, most recently
from
0e6527d to
fa99fd3
Compare
mdedetrich
commented
Oct 18, 2024
| @@ -23,13 +24,43 @@ lazy val root = (project in file(".")) | |||
| ) | |||
| }, | |||
| scriptedBufferLog := false, | |||
| scriptedSbt := "1.10.2", | |||
There was a problem hiding this comment.
Technically speaking we could find the lowest sbt version that this plugin can support and set scriptedSbt to this version but honestly I don't think its needed, anyone who will use this plugin will likely be running latest version of sbt anyways and we can always fix this later if needed
|
Hmm the scripted tests are still failing with @raboof Feel free to add onto this PR if you find the root cause, I am off for the day |
mdedetrich
force-pushed
the
use-sbt-github-actions
branch
from
fa99fd3 to
674f2c5
Compare
raboof
force-pushed
the
use-sbt-github-actions
branch
from
5c4ab89 to
b3bf4b5
Compare
raboof
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses sbt-github-actions to do tests and publishing, it copies an existing configuration from an sbt plugin so its known to work (i.e. see https://github.com/sbt/sbt-license-report/blob/main/build.sbt#L57-L87)