Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set scriptedSbt lowest support sbt version #73

Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 24, 2024

This PR sets scripted sbt version to the lowest version of sbt that still passes the tests. Note that if we implement some feature that requires a newer version of sbt we can always just increase this value, all this PR does is set the lowest version of sbt that we can reasonably claim we support.

I had to remove JDK 21 from the build matrix but this is due to an sbt internal detail (specifically older versions of sbt don't work with newer jdk's beause of sbt internals but this is not relevant for sbt plugins, this plugin will still support newer JDK's than 17).

@mdedetrich mdedetrich force-pushed the set-scripted-sbt-lowest-supported-version branch from dc33701 to 5873563 Compare October 24, 2024 07:28
@mdedetrich mdedetrich marked this pull request as draft October 24, 2024 07:29
@mdedetrich mdedetrich force-pushed the set-scripted-sbt-lowest-supported-version branch 3 times, most recently from be29da3 to d87f1c8 Compare October 24, 2024 07:44
@mdedetrich mdedetrich marked this pull request as ready for review October 24, 2024 07:50
@mdedetrich mdedetrich force-pushed the set-scripted-sbt-lowest-supported-version branch from d87f1c8 to d69e2be Compare October 24, 2024 07:51
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure: given the choice I think I'd rather be confident that the plugin works correctly with the latest sbt version (and jdk21) rather than with some old one. OTOH I suppose this makes raising the required version more of an intentional choice.

I'm OK with merging if you prefer it.

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Oct 24, 2024

I'm not sure: given the choice I think I'd rather be confident that the plugin works correctly with the latest sbt version (and jdk21) rather than with some old one. OTOH I suppose this makes raising the required version more of an intentional choice.

I'm OK with merging if you prefer it.

Yeah this is more so we can document the minimum version, there shouldn't be any breakages at all with JDK 21 because in any case we need to compile the plugin with JDK 8 (given that this is the floor for sbt community plugins unless there is something else that trumps this, i.e. some library dependency).

@mdedetrich mdedetrich merged commit cc0fb3d into sbt:main Oct 24, 2024
10 checks passed
@mdedetrich mdedetrich deleted the set-scripted-sbt-lowest-supported-version branch October 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants