Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sbt build load cleanly with Metals #600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .scalafmt.conf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
version = "3.2.1"
runner.dialect = scala213
runner.dialect = scala213source3
maxColumn = 100
project.git = true
align.preset = none
Expand Down
2 changes: 2 additions & 0 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ inThisBuild(
packageDoc / publishArtifact := "true" == System.getenv("CI"),
packageSrc / publishArtifact := "true" == System.getenv("CI"),
turbo := true,
semanticdbEnabled := true,
semanticdbVersion := "4.4.31",
useSuperShell := false // overlaps with MUnit test failure reports.
)
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import scala.annotation.implicitNotFound
import mdoc.internal.CompatClassloader
import mdoc.internal.worksheets.Compat._
import scala.meta.internal.inputs._
import scala.tools.nsc.plugins.Plugin

class MarkdownCompiler(
classpath: String,
Expand All @@ -52,7 +53,13 @@ class MarkdownCompiler(
def classpathEntries: Seq[Path] = global.classPath.asURLs.map(url => Paths.get(url.toURI()))

private val sreporter = new FilterStoreReporter(settings)
var global = new Global(settings, sreporter)
var global = new Global(settings, sreporter) {
// Disable the SemanticDB compiler plugin because it's not needed for
// Markdown evaluation. The primary motivation to disable the SemanticDB
// compiler plugin was to work around this bug here
// https://github.com/scalameta/scalameta/pull/2528
override protected def loadPlugins(): List[Plugin] = super.loadPlugins().filterNot(_.name == "semanticdb")
}
private def reset(): Unit = {
global = new Global(settings, sreporter)
}
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.5.7
sbt.version=1.6.1