Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scw): read body with unknown content-length #2406

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jan 31, 2025

From go doc:

	// ContentLength records the length of the associated content. The
	// value -1 indicates that the length is unknown. Unless Request.Method
	// is "HEAD", values >= 0 indicate that the given number of bytes may
	// be read from Body.

Some requests may have -1 as content-length and still have a body that we must read. A long list response received chunked for example.

@Codelax Codelax added the bug Something isn't working label Jan 31, 2025
@Codelax Codelax requested a review from remyleone as a code owner January 31, 2025 09:20
@remyleone remyleone added this pull request to the merge queue Jan 31, 2025
Merged via the queue into scaleway:master with commit c830312 Jan 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants