feat(domain): add waiters for registrar API #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jremy42
changed the title
Codelax
reviewed
Feb 13, 2025
api/domain/v2beta1/domain_utils.go
Outdated
Comment on lines
275
to
278
| if _, isTransient := transientStatuses[resp.AutoRenewStatus]; isTransient { | ||
| return resp, false, nil | ||
| } | ||
| return nil, false, errors.New("unexpected auto_renew status: " + string(resp.AutoRenewStatus)) |
There was a problem hiding this comment.
Regardless of the transient state, it should continue if no terminal status is encountered. A new transient state in the API should not make the waiter fail.
Laure-di
reviewed
Feb 13, 2025
jremy42
force-pushed
the
domain/add_waiters_for_registar_api
branch
from
4ce4c46 to
86de12b
Compare
remyleone
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.