Skip to content

Commit

Permalink
ci: remove dns deployement on preprod env (#4000)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthprost authored Jul 11, 2024
1 parent e5d59ec commit 4b9c221
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/deploy-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
env:
IMAGE_NAME: rg.fr-par.scw.cloud/ultraviolet/storybook
DEPLOYMENT_NAME: "storybook"
SCW_DNS: ${{ github.ref_name == 'main' && 'storybook.ultraviolet.scaleway.com' || '' }}
steps:
- uses: actions/checkout@v4
- name: Inject slug/short variables
Expand Down Expand Up @@ -93,7 +94,7 @@ jobs:
with:
type: "deploy"
# scw_dns: ${{ secrets.SCW_DNS }}
scw_dns: storybook.ultraviolet.scaleway.com
scw_dns: ${{ env.SCW_DNS }}
root_zone: ${{ env.BRANCH_SLUG == 'main' }}
scw_access_key: ${{ secrets.SCW_ACCESS_KEY }}
scw_secret_key: ${{ secrets.SCW_SECRET_KEY }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/teardown_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
env:
IMAGE_NAME: rg.fr-par.scw.cloud/ultraviolet/storybook
STORYBOOK_DEPLOYMENT_NAME: storybook
SCW_DNS: ${{ github.ref_name == 'main' && 'storybook.ultraviolet.scaleway.com' || '' }}

steps:
- uses: actions/checkout@v4 # v4.1.4
Expand All @@ -26,7 +27,7 @@ jobs:
id: deploy
with:
type: "teardown"
scw_dns: ${{ secrets.SCW_DNS }}
scw_dns: ${{ env.SCW_DNS }}
root_zone: ${{ env.BRANCH_SLUG == 'main' }}
scw_access_key: ${{ secrets.SCW_ACCESS_KEY }}
scw_secret_key: ${{ secrets.SCW_SECRET_KEY }}
Expand Down

0 comments on commit 4b9c221

Please sign in to comment.