chore(devdeps): update dependency @scaleway/eslint-config-react to v5 (…

…#4569) * chore(devdeps): update dependency @scaleway/eslint-config-react to v5 * chore(eslint): update config Signed-off-by: Alexandre Philibeaux <[email protected]> --------- Signed-off-by: Alexandre Philibeaux <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alexandre Philibeaux <[email protected]>
scaleway · Dec 11, 2024 · 65d862c · 65d862c
1 parent 9d27e8b
commit 65d862c
Show file tree

Hide file tree

Showing 32 changed files with 113 additions and 169 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -9,7 +9,7 @@ turbo.json               @scaleway/front-kernel
 biome.json               @scaleway/front-kernel
 eslint.config.mjs         @scaleway/front-kernel
 pnpm-workspace.yaml      @scaleway/front-kernel
-svgo.config.cjs           @scaleway/front-kernel
+svgo.config.mjs           @scaleway/front-kernel
 .github                  @scaleway/front-kernel
 .changeset/config.json    @scaleway/front-kernel
 .aws                     @scaleway/front-kernel
diff --git a/.gitignore b/.gitignore
@@ -46,3 +46,6 @@ tools/*/.turbo
 # typescript
 *.tsbuildinfo
 .tsbuildinfo
+
+# next
+next-env.d.ts*
diff --git a/.oxlintrc.json b/.oxlintrc.json
@@ -35,13 +35,12 @@
     }
   ],
   "rules": {
-    "@typescript/no-explicit-any": "warn",
-    "@typescript-eslint/no-unused-expressions": "warn",
-    "@typescript-eslint/ban-tslint-comment": "warn",
+    "@typescript-eslint/no-unused-expressions": "error",
+    "@typescript-eslint/ban-tslint-comment": "error",
     "@typescript-eslint/consistent-indexed-object-style": "error",
     "@typescript-eslint/consistent-type-definitions": ["error", "type"],
     "@typescript-eslint/explicit-function-return-type": "off",
-    "@typescript-eslint/no-explicit-any": "warn",
+    "@typescript-eslint/no-explicit-any": "error",
     "@typescript-eslint/prefer-enum-initializers": "off",
     "@typescript-eslint/prefer-function-type": "off",
     "@typescript-eslint/prefer-literal-enum-member": "off",
@@ -75,13 +74,13 @@
     "import/namespace": "off",
     "import/no-default-export": "off",
     "import/no-duplicates": "off",
-    "import/unambiguous": "warn",
+    "import/unambiguous": "off",
     "react-perf/jsx-no-jsx-as-prop": "off",
     "react-perf/jsx-no-new-array-as-prop": "off",
     "react-perf/jsx-no-new-function-as-prop": "off",
     "react-perf/jsx-no-new-object-as-prop": "off",
     "react/jsx-no-useless-fragment": "off",
-    "react/iframe-missing-sandbox": "warn",
+    "react/iframe-missing-sandbox": "error",
     "react/jsx-no-target-blank": "off",
     "react/react-in-jsx-scope": "off",
     "unicorn/error-message": "off",

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -15,6 +15,8 @@ const disableRules = {
   // ---- biome rules ----
   'import/order': 'off',
   'import/no-unresolved': 'off',
+  '@stylistic/no-extra-semi': 'off',
+  '@stylistic/brace-style': 'off',
 
   // to check
   'react/no-unused-prop-types': 'off',
@@ -36,6 +38,7 @@ export default [
       '**/coverage/',
       '.storybook',
       'eslint.config.mjs',
+      'next-env.d.ts',
     ],
   },
   {

diff --git a/examples/next-login/global.d.ts b/examples/next-login/global.d.ts
@@ -1,4 +1,4 @@
-declare module '*.svg' {
+export declare module '*.svg' {
   const content: string
   export default content
 }
diff --git a/examples/next-login/tsconfig.json b/examples/next-login/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "@scaleway/tsconfig",
   "compilerOptions": {
+    "types": ["next", "next/image-types/global"],
     "target": "es5",
     "module": "esnext",
     "jsx": "preserve",

diff --git a/examples/next-simple/global.d.ts b/examples/next-simple/global.d.ts
@@ -1,4 +1,4 @@
-declare module '*.svg' {
+export declare module '*.svg' {
   const content: string
   export default content
 }
diff --git a/examples/next-simple/tsconfig.json b/examples/next-simple/tsconfig.json
@@ -20,5 +20,6 @@
     "**/*.ts",
     "**/*.tsx"
   ],
+
   "exclude": ["node_modules"]
 }
diff --git a/jest-axe.d.ts b/jest-axe.d.ts
@@ -2,7 +2,7 @@
 // because `jest-axe` depends on `@types/jest`, which we don't want
 // because we use `@jest/globals`
 
-declare module 'jest-axe' {
+export declare module 'jest-axe' {
   import type {
     AxeResults,
     ImpactValue,

diff --git a/package.json b/package.json
@@ -27,8 +27,10 @@
     "format": "biome check --linter-enabled=false --write .",
     "format:check": "biome check --linter-enabled=false --verbose .",
     "format:ci": "biome ci --linter-enabled=false .",
-    "lint:fix": "pnpm run lint --fix",
     "lint": "eslint --report-unused-disable-directives --cache .",
+    "lint:fix": "pnpm run lint --fix",
+    "oxc": "oxlint -c .oxlintrc.json",
+    "oxc:fix": "pnpm run oxlint --fix",
     "prepare": "husky",
     "tokens:update": "node ./scripts/figma-synchronise-tokens.mjs && pnpm run format packages/themes/src/themes/console",
     "icons:update": "tsx ./scripts/generate-icons-file.ts && biome format --write packages/icons",

diff --git a/packages/form/src/components/NumberInputField/__tests__/__snapshots__/index.test.tsx.snap b/packages/form/src/components/NumberInputField/__tests__/__snapshots__/index.test.tsx.snap
@@ -325,7 +325,6 @@ exports[`NumberInputField > should render correctly 1`] = `
                 <svg
                   class="emotion-9 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     clip-rule="evenodd"
@@ -362,7 +361,6 @@ exports[`NumberInputField > should render correctly 1`] = `
                 <svg
                   class="emotion-20 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     d="M10.75 4.75a.75.75 0 0 0-1.5 0v4.5h-4.5a.75.75 0 0 0 0 1.5h4.5v4.5a.75.75 0 0 0 1.5 0v-4.5h4.5a.75.75 0 0 0 0-1.5h-4.5z"
@@ -632,7 +630,6 @@ exports[`NumberInputField > should render correctly disabled 1`] = `
                 <svg
                   class="emotion-9 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     clip-rule="evenodd"
@@ -671,7 +668,6 @@ exports[`NumberInputField > should render correctly disabled 1`] = `
                 <svg
                   class="emotion-9 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     d="M10.75 4.75a.75.75 0 0 0-1.5 0v4.5h-4.5a.75.75 0 0 0 0 1.5h4.5v4.5a.75.75 0 0 0 1.5 0v-4.5h4.5a.75.75 0 0 0 0-1.5h-4.5z"
@@ -1011,7 +1007,6 @@ exports[`NumberInputField > should trigger event onMinCrossed & onMaxCrossed 1`]
                 <svg
                   class="emotion-9 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     clip-rule="evenodd"
@@ -1049,7 +1044,6 @@ exports[`NumberInputField > should trigger event onMinCrossed & onMaxCrossed 1`]
                 <svg
                   class="emotion-20 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     d="M10.75 4.75a.75.75 0 0 0-1.5 0v4.5h-4.5a.75.75 0 0 0 0 1.5h4.5v4.5a.75.75 0 0 0 1.5 0v-4.5h4.5a.75.75 0 0 0 0-1.5h-4.5z"
@@ -1327,7 +1321,6 @@ exports[`NumberInputField > should trigger events correctly 1`] = `
                 <svg
                   class="emotion-9 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     clip-rule="evenodd"
@@ -1364,7 +1357,6 @@ exports[`NumberInputField > should trigger events correctly 1`] = `
                 <svg
                   class="emotion-9 emotion-10"
                   viewBox="0 0 20 20"
-                  xmlns="http://www.w3.org/2000/svg"
                 >
                   <path
                     d="M10.75 4.75a.75.75 0 0 0-1.5 0v4.5h-4.5a.75.75 0 0 0 0 1.5h4.5v4.5a.75.75 0 0 0 1.5 0v-4.5h4.5a.75.75 0 0 0 0-1.5h-4.5z"

diff --git a/packages/form/src/components/TextInputField/__tests__/__snapshots__/index.test.tsx.snap b/packages/form/src/components/TextInputField/__tests__/__snapshots__/index.test.tsx.snap
@@ -682,12 +682,11 @@ exports[`TextInputField > should render correctly notice 1`] = `
         >
           <svg
             class="emotion-12 emotion-13"
-            viewBox="0 0 16 16"
-            xmlns="http://www.w3.org/2000/svg"
+            viewBox="0 0 20 20"
           >
             <path
               clip-rule="evenodd"
-              d="M15 8A7 7 0 1 1 1 8a7 7 0 0 1 14 0M9 5a1 1 0 1 1-2 0 1 1 0 0 1 2 0M6.75 8a.75.75 0 0 0 0 1.5h.75v1.75a.75.75 0 0 0 1.5 0v-2.5A.75.75 0 0 0 8.25 8z"
+              d="M10 3.5a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13M2 10a8 8 0 1 1 16 0 8 8 0 0 1-16 0m7.25-3.02a.75.75 0 0 1 .75-.75h.006a.75.75 0 0 1 .75.75v.005a.75.75 0 0 1-.75.75H10a.75.75 0 0 1-.75-.75zm.244 3.16a.75.75 0 0 1-.434-1.415l.034-.017c1.035-.517 2.2.418 1.92 1.54l-.508 2.03a.75.75 0 0 1 .434 1.414l-.034.016c-1.035.518-2.2-.417-1.92-1.54z"
               fill-rule="evenodd"
             />
           </svg>

diff --git a/...ges/icons/src/components/Icon/assets/default-outline/adjustments-horizontal.svg b/...ges/icons/src/components/Icon/assets/default-outline/adjustments-horizontal.svg
diff --git a/packages/ui/src/components/Banner/assets/default-image-small.svg b/packages/ui/src/components/Banner/assets/default-image-small.svg