Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new product illustration #4672

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Feature

Summarise concisely:

What is expected?

New product illustration dediboxGpu

@lisalupi lisalupi requested a review from a team January 16, 2025 15:17
@lisalupi lisalupi self-assigned this Jan 16, 2025
@lisalupi lisalupi requested review from BABAK0T0 and Lawndlwd and removed request for a team January 16, 2025 15:17
@lisalupi lisalupi requested a review from matthprost as a code owner January 16, 2025 15:17
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: f5fc8e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ultraviolet/illustrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi marked this pull request as draft January 16, 2025 16:09
@lisalupi
Copy link
Contributor Author

wrong illustrations, waiting for the correct ones

@lisalupi lisalupi force-pushed the feat/product-illustration-dedibox-gpu branch from 511539a to 87303be Compare January 22, 2025 08:59
@lisalupi lisalupi marked this pull request as ready for review January 22, 2025 09:00
@lisalupi lisalupi merged commit f68a6e6 into main Jan 22, 2025
13 checks passed
@lisalupi lisalupi deleted the feat/product-illustration-dedibox-gpu branch January 22, 2025 09:44
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c7e0f91) to head (f5fc8e3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #4672       +/-   ##
==========================================
- Coverage   89.17%       0   -89.18%     
==========================================
  Files         227       0      -227     
  Lines        7957       0     -7957     
  Branches     3611       0     -3611     
==========================================
- Hits         7096       0     -7096     
+ Misses        861       0      -861     

see 227 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e0f91...f5fc8e3. Read the comment docs.

@scaleway-bot scaleway-bot mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants