Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): alignement issue #4711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Wrong alignement on checkbox children used as label not allowing us to change the children size.

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-01-29 at 09 51 52 Screenshot 2025-01-29 at 09 51 57

@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners January 29, 2025 09:03
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 586d8e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost self-assigned this Jan 29, 2025
@matthprost matthprost requested a review from a team January 29, 2025 09:03
@matthprost matthprost added the bug Something isn't working label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (2529980) to head (586d8e6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/Checkbox/index.tsx 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4711      +/-   ##
==========================================
- Coverage   88.98%   88.97%   -0.01%     
==========================================
  Files         227      227              
  Lines        7970     7974       +4     
  Branches     3617     3621       +4     
==========================================
+ Hits         7092     7095       +3     
- Misses        878      879       +1     
Files with missing lines Coverage Δ
packages/ui/src/components/Checkbox/index.tsx 99.12% <92.30%> (-0.88%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2529980...586d8e6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants