Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File publisher support & tests #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

igrishaev
Copy link

As described in #10 , there is a pull-request to support File and Path body types. Tests added.

@igrishaev
Copy link
Author

Gentle ping? cc @schmee @borkdude

@borkdude
Copy link
Contributor

@igrishaev I'm not the maintainer of this lib, but babashka.http-client started of with pretty much the code from this library and has had this feature since a long time:

https://github.com/babashka/http-client/blob/c4071b0a0918f88f79e91b154a5b5c09129c7bb4/src/babashka/http_client/internal.clj#L216-L222

@igrishaev
Copy link
Author

@borkdude That's really great you have that bits in your client, that's good to know. But the company I'm working for at the moment has built everything on top of java-http-clj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants