Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: trivial typo in quantile regression and time series regression files #365

Conversation

thibaultcordier
Copy link
Collaborator

@thibaultcordier thibaultcordier commented Oct 17, 2023

Description

In both files it should read from rather than form.

Fixes #364

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • See WARNING: Deprecated path with changes when importing MapieQuantileRegressor and MapieTimeSeriesRegressor

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Change "form" to "from"
Change "form" to "from"
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (614293e) 100.00% compared to head (6c98511) 100.00%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #365    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        39            
  Lines         4616      4618     +2     
  Branches       487       757   +270     
==========================================
+ Hits          4616      4618     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Change pandas version
@thibaultcordier thibaultcordier marked this pull request as ready for review December 11, 2023 12:08
@thibaultcordier thibaultcordier merged commit 6a880c5 into master Dec 12, 2023
8 checks passed
@thibaultcordier thibaultcordier deleted the 364-trivial-typo-in-quantile_regressionpy-and-time_series_regressionpy branch December 12, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trivial typo in quantile_regression.py and time_series_regression.py
3 participants