-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] updated reference for Residual Normalised Score #380
[DOC] updated reference for Residual Normalised Score #380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 39 39
Lines 4616 4618 +2
Branches 487 757 +270
==========================================
+ Hits 4616 4618 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR ! Could you just update the file history.rst so that we can follow to changes for the next release. Once it's done you'll be able to merge your PR
Sure :) * Fix reference for residual normalised score in documentation |
@vincentblot28 thanks a lot for approving the changes ! I'm sorry for asking but, since I still am quite unfamiliar with MAPIE's merging policy, I'm unsure about whether PRs should be merged by contributors or owners/maintainers. Let me know if you need any additional action from me :) |
@mehdi-elion, your PR is ready, you can merge it ! Thank you for taking in charge this issue |
Awesome! Unfortunately I fear that don't have write access / merging rights (yet ?) to MAPIE's repository. |
Don't worry :) do you see the green "Merge pull request" button below this comment? If so, you have the right to finish the pull request. If not, no problem, I'll merge the pull request for you straight away. |
@thibaultcordier I actually can't see the green "Merge pull request" button at the end of this thread ^^' |
No problem, I'll merge your pull request. Sorry for the wait and thanks again :) |
Description
Changed the reference for the residual normalized score from
to
Fixes #366
Type of change
This is a simple documentation update.
How Has This Been Tested?
This has been tested according to the items of the checklist below.
Checklist
make lint
make type-check
make tests
make coverage
make doc