Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: integration test JackknifeAfterBootstrapRegressor #556

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

jawadhussein462
Copy link
Collaborator

Description

Implement Mapie v1 JackknifeAfterBootstrapRegressor integration tests

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [] I have read the contributing guidelines
  • [] I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully and without warnings : make doc

Copy link
Collaborator

@Valentin-Laurent Valentin-Laurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🤟🏻
Few remarks here and in the code:

  • Run make v1-type-check
  • Missing test cases:
    • Method = minmax (the most important missing one I think)
    • Conf score = absolute
    • "allow_infinite_bounds": True,

mapie_v1/integration_tests/tests/test_regression.py Outdated Show resolved Hide resolved
mapie_v1/integration_tests/tests/test_regression.py Outdated Show resolved Hide resolved
@Valentin-Laurent Valentin-Laurent merged commit e598f7b into v1 Dec 9, 2024
8 checks passed
@Valentin-Laurent Valentin-Laurent deleted the v1-integration-test-jackknife branch December 9, 2024 16:27
Valentin-Laurent pushed a commit that referenced this pull request Dec 9, 2024
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Dec 17, 2024
TEST: add integration test for JackknifeAfterBootstrapRegressor
jawadhussein462 added a commit that referenced this pull request Dec 20, 2024
TEST: add integration test for JackknifeAfterBootstrapRegressor
jawadhussein462 added a commit that referenced this pull request Dec 20, 2024
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Dec 29, 2024
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 5, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 7, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 7, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 8, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 9, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 10, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 15, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 15, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 21, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 22, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 23, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 24, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Valentin-Laurent pushed a commit that referenced this pull request Jan 28, 2025
TEST: add integration test for JackknifeAfterBootstrapRegressor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants