ENH: improve jackknife docstring #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Few comments here and in the code:
- There are 2 "TODOs" left in the docstrings. I think we can wait for the first one because I see some refactoring later on here. But the second one can be completed:
See: TODO : reference conformity score classes or documentation
mapie_v1/regression.py
Outdated
| n_bootstraps : int, default=100 | ||
| The number of bootstrap resamples to generate for the | ||
| jackknife-after-bootstrap procedure. | ||
| Note: The "base" method is not authorized and should not be used. |
There was a problem hiding this comment.
Good point mentioning this. Suggestion:
Suggested change
| Note: The "base" method is not authorized and should not be used. | |
| Note: The "base" method is not mentioned in the conformal inference literature for Jackknife after bootstrap strategies, hence not provided here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1 #561 +/- ##
======================================
Coverage ? 100.00%
======================================
Files ? 62
Lines ? 6013
Branches ? 449
======================================
Hits ? 6013
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Valentin-Laurent
approved these changes
Dec 13, 2024
Valentin-Laurent
pushed a commit
that referenced
this pull request
Dec 17, 2024
ENH: improve jackknife docstring
jawadhussein462
added a commit
that referenced
this pull request
Dec 20, 2024
ENH: improve jackknife docstring
jawadhussein462
added a commit
that referenced
this pull request
Dec 20, 2024
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Dec 29, 2024
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 5, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 7, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 7, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 8, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 9, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 10, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 15, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 15, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 21, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 22, 2025
ENH: improve jackknife docstring
Valentin-Laurent
pushed a commit
that referenced
this pull request
Jan 23, 2025
ENH: improve jackknife docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.