REFACTO: split MapieRegressor.fit into .init_fit, .fit_estimator, and .conformalize, split EnsembleRegressor.fit into .fit_single_estimator and .fit_multi_estimators, remove EnsembleEstimator useless interface #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .conformalize, split EnsembleRegressor .fit into .fit_single_estimator and .fit_multi_estimators, remove EnsembleEstimator useless interface
Valentin-Laurent
requested review from
jawadhussein462,
vincentblot28 and
thibaultcordier
jawadhussein462
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring, in preparation for v1:
MapieRegressor.fitinto.init_fit,.fit_estimator, and.conformalize. Note: theMapieRegressor.fitmethod now just calls those 3 sub-methods, and the public API is not broken.EnsembleRegressor.fitinto.fit_single_estimatorand.fit_multi_estimators. Note: theEnsembleRegressor.fitmethod has been kept (and calls those 2 sub-methods) to avoid breaking this low-level API, but is now deprecatedEnsembleEstimatorinterface, that is not used (nothing in the code actually requires this interface), and will not be relevant anyways in future refactoring