Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: restucture the MapieQuantileRegressor Fit - Split the fit into prefit_estimators, fit_estimators and conformalize #565

Closed
wants to merge 22 commits into from
Closed

REFACTOR: restucture the MapieQuantileRegressor Fit - Split the fit into prefit_estimators, fit_estimators and conformalize #565

wants to merge 22 commits into from

Conversation

jawadhussein462
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully and without warnings : make doc

sd29206 and others added 22 commits December 9, 2024 17:41
@Valentin-Laurent
v1 branch - initial commit (made of a bunch of wip commits squashed t…
d592283 
…ogether)
@Valentin-Laurent
DOC: reorganize documentation, add migration_guide in doc in .rst for…
085273b 
…mat, make left navigation bar more usable (#540)
@Valentin-Laurent
DOC: add groups in .conformalize for CrossConformalRegression, improv…
434e420 
…e docstrings (#543)
@Valentin-Laurent
TEST & DOC : add integration tests for CrossConformalRegressor, finis…
47ea0cf 
…h related docstring for param cv (#544)
@Valentin-Laurent
DOC: add decision trees (#546)
4b3b02b
@jawadhussein462 @Valentin-Laurent
REFACTOR & ENH: Split .fit into .fit_single_estimator and fit_multi_e…
b2ad363 
…stimator in MapieRegressor and EnsembleRegressor, implement (wip) CrossConformalRegressor (#545)
@Valentin-Laurent
REFACTOR: make SplitConformalRegressor attributes private, improve v1…
96f5da0 
… utils
@Valentin-Laurent
CHORE: add -k option to launch specific v1 integration tests from MAK…
f4d7add 
…EFILE
@Valentin-Laurent
ENH: implement checks for CrossConformalRegression, make utils.py non…
974e83a 
…-public
@Valentin-Laurent
TESTS: fix and improve v1 integration tests
9508c3e
@Valentin-Laurent
FIX: back-end edge case making v1 tests fail
f892303
@Valentin-Laurent
ENH: fix and finish CrossConformalRegressor implementation
ca1833d
@Valentin-Laurent
ENH: remove optimize_beta warning in back-end (optimize_beta has been…
370ca6d 
… introduced only for ENBPI in the scientific literature, but it works for all regression methods, so let's support it)
@jawadhussein462 @Valentin-Laurent
DOCS: Add MAPIE v1 docstrings to the DOC (#554)
cd00088 
* DOCS: Add MAPIE v1 regression docstrings to ReadTheDoc, fix warnings
@Valentin-Laurent
CHORE: set-up mypy for v1 code, add it to CI, fix existing warnings
dbffafa
@Valentin-Laurent
CHORE: set-up mypy for v1 code, add it to CI, fix existing warnings
c979c23
@Valentin-Laurent
CHORE: remove type check v1 from CI
6e078f4
@jawadhussein462 @Valentin-Laurent
TEST: add integration test for JackknifeAfterBootstrapRegressor (#556)
0c49868 
TEST: add integration test for JackknifeAfterBootstrapRegressor
@Valentin-Laurent
FIX: correct warnings and error messages to match the v1 API
47cd981
@jawadhussein462
Merge pull request #558 from scikit-learn-contrib/v1-update-parameter…
0cbc31a 
…s-name

FIX: correct warnings and error messages to match the v1 API
@Valentin-Laurent
ENH: implement JackknifeAfterBootstrap regressor, fix integration tes…
f1b0707 
…ts (#559)

* ENH: implement JackknifeAfterBootstrap regressor
@qroa
REFACTOR: restucture the MapieQuantileRegressor Fit - Split the fit i…
bd243a8 
…nto prefit_estimators, fit_estimators and conformalize
@jawadhussein462 jawadhussein462 changed the title Factorize cqr split fit REFACTOR: restucture the MapieQuantileRegressor Fit - Split the fit into prefit_estimators, fit_estimators and conformalize Dec 16, 2024
@jawadhussein462 jawadhussein462 deleted the factorize_cqr_split_fit branch December 16, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawadhussein462 @Valentin-Laurent @qroa