Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: remove random_state from EnsembleRegressor (not used) #597

Merged
merged 2 commits into from
Jan 15, 2025
Merged

REFACTOR: remove random_state from EnsembleRegressor (not used) #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9314593
REFACTOR: remove random_state from EnsembleRegressor (not used)
Valentin-Laurent Jan 13, 2025
3ae3be7
REFACTOR: remove random_state from EnsembleRegressor (not used)
Valentin-Laurent Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions mapie/estimator/regressor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ class EnsembleRegressor:

By default ``0``.

random_state: Optional[Union[int, RandomState]]
Pseudo random number generator state used for random sampling.
Pass an int for reproducible output across multiple function calls.

By default ``None``.

Attributes
----------
single_estimator_: sklearn.RegressorMixin
Expand Down Expand Up @@ -161,7 +155,6 @@ def __init__(
cv: Optional[Union[int, str, BaseCrossValidator]],
agg_function: Optional[str],
n_jobs: Optional[int],
random_state: Optional[Union[int, np.random.RandomState]],
test_size: Optional[Union[int, float]],
verbose: int
):
Expand All @@ -170,7 +163,6 @@ def __init__(
self.cv = cv
self.agg_function = agg_function
self.n_jobs = n_jobs
self.random_state = random_state
self.test_size = test_size
self.verbose = verbose

Expand Down
1 change: 0 additions & 1 deletion mapie/regression/regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ def init_fit(
cv,
agg_function,
self.n_jobs,
self.random_state,
self.test_size,
self.verbose
)
Expand Down
1 change: 0 additions & 1 deletion mapie/tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ def test_warning_when_import_from_estimator():
cv=3,
agg_function="mean",
n_jobs=1,
random_state=0,
test_size=0.2,
verbose=0,
)
2 changes: 0 additions & 2 deletions mapie/tests/test_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,6 @@ def test_aggregate_with_mask_with_invalid_agg_function() -> None:
KFold(n_splits=5, random_state=None, shuffle=True),
"nonsense",
None,
random_state,
0.20,
False
)
Expand Down Expand Up @@ -1032,7 +1031,6 @@ def test_deprecated_ensemble_regressor_fit_warning() -> None:
KFold(n_splits=5, random_state=None, shuffle=True),
"nonsense",
None,
random_state,
0.20,
False
)
Expand Down
Loading