Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: update release checklist and max sklearn dependencies (see issue #574) #601

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions RELEASE_CHECKLIST.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Release checklist

- [ ] Update the version number with `bump2version major|minor|patch`
- [ ] Push new tag to your commit: `git push --tags`
- [ ] Edit HISTORY.rst and AUTHORS.rst to make sure it’s up-to-date and add release date
- [ ] Check whether any new files need to go in MANIFEST.in
- [ ] Make sure tests run, pass and cover 100% of the package:
Expand All @@ -11,19 +9,19 @@
* `make coverage`
- [ ] Make sure documentation builds without warnings and shows nicely:
* `make doc`
- Commit every change from the steps below
- [ ] Update the version number with `bump2version major|minor|patch`
- [ ] Push new tag to your commit: `git push --tags`
- [ ] Build source distribution:
* `make clean-build`
* `make build`
- [ ] Check that your package is ready for publication: `twine check dist/*`
- [ ] Make sure everything is committed and pushed: `git push origin master`
- [ ] Upload it to TestPyPi: `twine upload --repository-url https://test.pypi.org/legacy/ dist/*`
- [ ] Upload it to TestPyPi: `twine upload --repository-url https://test.pypi.org/legacy/ dist/*` (you need to create an account on test.pypi.org first,
then an API key, and ask one the existing MAPIE maintainer to add you as a maintainer)
- [ ] Test upload on TestPyPi:
* `cd`
* `conda activate`
* `conda create -n test-mapie --yes python=3.9`
* `conda activate test-mapie`
* create a new empty virtual environment
* `pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ mapie`
* `conda activate`
* `conda env remove -n test-mapie`
- [ ] Create new release on GitHub for this tag.
- [ ] Merge the automatically created pull request on https://github.com/conda-forge/mapie-feedstock
- [ ] Merge the automatically created pull request on https://github.com/conda-forge/mapie-feedstock. You need to be added as a maintainer on this repo first. To create the pull request
manually to avoid waiting for automation, create an issue with the name `@conda-forge-admin, please update version`
2 changes: 1 addition & 1 deletion environment.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:
- pytest=6.2.5
- pytest-cov=3.0.0
- python=3.10
- scikit-learn
- scikit-learn<1.6.0
- sphinx=4.3.2
- sphinx-gallery=0.10.1
- sphinx_rtd_theme=1.0.0
Expand Down
2 changes: 1 addition & 1 deletion requirements.dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ numpy==1.22.3
pandas==1.3.5
pytest==6.2.5
pytest-cov==3.0.0
scikit-learn
scikit-learn<1.6.0
sphinx==4.3.2
sphinx-gallery==0.10.1
sphinx_rtd_theme==1.0.0
Expand Down
Loading