fix(gemini): make tests parallel

scylladb · Jul 3, 2023 · 0fe2312 · 0fe2312
1 parent 3e6d9a4
commit 0fe2312
Show file tree

Hide file tree

Showing 14 changed files with 42 additions and 1 deletion.
diff --git a/pkg/auth/auth_test.go b/pkg/auth/auth_test.go
@@ -24,6 +24,7 @@ import (
 )
 
 func TestSetAuthenticator(t *testing.T) {
+	t.Parallel()
 	username := "username"
 	password := "password"
 	expectedAuthenticator := gocql.PasswordAuthenticator{
@@ -60,6 +61,7 @@ func TestSetAuthenticator(t *testing.T) {
 	}
 	for name, test := range tests {
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
 			authenticator, err := auth.BuildAuthenticator(
 				test.input.username,
 				test.input.password,

diff --git a/pkg/generators/generator_test.go b/pkg/generators/generator_test.go
@@ -26,6 +26,7 @@ import (
 )
 
 func TestGenerator(t *testing.T) {
+	t.Parallel()
 	table := &typedef.Table{
 		Name:          "tbl",
 		PartitionKeys: generators.CreatePkColumns(1, "pk"),

diff --git a/pkg/generators/statement_generator_test.go b/pkg/generators/statement_generator_test.go
@@ -30,6 +30,7 @@ func options(cql string) []string {
 }
 
 func TestGetCreateSchema(t *testing.T) {
+	t.Parallel()
 	ks := typedef.Keyspace{Name: "ks1"}
 	tests := map[string]struct {
 		table *typedef.Table
@@ -169,6 +170,7 @@ func TestGetCreateSchema(t *testing.T) {
 
 	for name, test := range tests {
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
 			got := generators.GetCreateTable(test.table, ks)
 			if diff := cmp.Diff(got, test.want); diff != "" {
 				t.Fatalf(diff)

diff --git a/pkg/joberror/joberror_test.go b/pkg/joberror/joberror_test.go
@@ -29,6 +29,7 @@ import (
 )
 
 func TestParallel(t *testing.T) {
+	t.Parallel()
 	wg := sync.WaitGroup{}
 	resultList := joberror.NewErrorList(1000)
 	expectedList := joberror.NewErrorList(1000)
@@ -69,6 +70,7 @@ func TestParallel(t *testing.T) {
 }
 
 func TestErrorSerialization(t *testing.T) {
+	t.Parallel()
 	expected := []byte(`{"timestamp":"2020-02-01T00:00:00Z","message":"Some Message","query":"Some Query","stmt-type":"Some Type"}`)
 	result, err := json.Marshal(joberror.JobError{
 		Timestamp: time.Date(2020, 02, 01, 0, 0, 0, 0, time.UTC),
@@ -86,6 +88,7 @@ func TestErrorSerialization(t *testing.T) {
 }
 
 func TestErrorListSerialization(t *testing.T) {
+	t.Parallel()
 	//nolint:lll
 	expected := []byte(`[{"timestamp":"2020-02-01T00:00:00Z","message":"Some Message 0","query":"Some Query 0","stmt-type":"Some Stmt Type 0"},{"timestamp":"2020-02-02T00:00:00Z","message":"Some Message 1","query":"Some Query 1","stmt-type":"Some Stmt Type 1"},{"timestamp":"2020-02-03T00:00:00Z","message":"Some Message 2","query":"Some Query 2","stmt-type":"Some Stmt Type 2"},{"timestamp":"2020-02-04T00:00:00Z","message":"Some Message 3","query":"Some Query 3","stmt-type":"Some Stmt Type 3"},{"timestamp":"2020-02-05T00:00:00Z","message":"Some Message 4","query":"Some Query 4","stmt-type":"Some Stmt Type 4"},{"timestamp":"2020-02-06T00:00:00Z","message":"Some Message 5","query":"Some Query 5","stmt-type":"Some Stmt Type 5"},{"timestamp":"2020-02-07T00:00:00Z","message":"Some Message 6","query":"Some Query 6","stmt-type":"Some Stmt Type 6"},{"timestamp":"2020-02-08T00:00:00Z","message":"Some Message 7","query":"Some Query 7","stmt-type":"Some Stmt Type 7"},{"timestamp":"2020-02-09T00:00:00Z","message":"Some Message 8","query":"Some Query 8","stmt-type":"Some Stmt Type 8"},{"timestamp":"2020-02-10T00:00:00Z","message":"Some Message 9","query":"Some Query 9","stmt-type":"Some Stmt Type 9"}]`)
 	lst := joberror.NewErrorList(1000)

diff --git a/pkg/murmur/murmur_test.go b/pkg/murmur/murmur_test.go
@@ -21,6 +21,7 @@ import (
 )
 
 func TestRotl(t *testing.T) {
+	t.Parallel()
 	tests := []struct {
 		in, rotate, exp int64
 	}{
@@ -38,6 +39,7 @@ func TestRotl(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(fmt.Sprintf("%d >> %d", test.in, test.rotate), func(t *testing.T) {
+			t.Parallel()
 			if v := rotl(test.in, uint8(test.rotate)); v != test.exp {
 				t.Fatalf("expected %d got %d", test.exp, v)
 			}
@@ -46,6 +48,7 @@ func TestRotl(t *testing.T) {
 }
 
 func TestFmix(t *testing.T) {
+	t.Parallel()
 	tests := []struct {
 		in, exp int64
 	}{
@@ -58,6 +61,7 @@ func TestFmix(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(strconv.Itoa(int(test.in)), func(t *testing.T) {
+			t.Parallel()
 			if v := fmix(test.in); v != test.exp {
 				t.Fatalf("expected %d got %d", test.exp, v)
 			}
@@ -66,6 +70,7 @@ func TestFmix(t *testing.T) {
 }
 
 func TestMurmur3H1_CassandraSign(t *testing.T) {
+	t.Parallel()
 	key, err := hex.DecodeString("00104327529fb645dd00b883ec39ae448bb800000400066a6b00")
 	if err != nil {
 		t.Fatal(err)
@@ -80,6 +85,8 @@ func TestMurmur3H1_CassandraSign(t *testing.T) {
 
 // Test the implementation of murmur3
 func TestMurmur3H1(t *testing.T) {
+	t.Parallel()
+
 	// these examples are based on adding a index number to a sample string in
 	// a loop. The expected values were generated by the java datastax murmur3
 	// implementation. The number of examples here of increasing lengths ensure

diff --git a/pkg/replication/replication_test.go b/pkg/replication/replication_test.go
@@ -21,6 +21,7 @@ import (
 )
 
 func TestToCQL(t *testing.T) {
+	t.Parallel()
 	tests := map[string]struct {
 		rs   *replication.Replication
 		want string
@@ -36,6 +37,7 @@ func TestToCQL(t *testing.T) {
 	}
 	for name, test := range tests {
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
 			got := test.rs.ToCQL()
 			if got != test.want {
 				t.Fatalf("expected '%s', got '%s'", test.want, got)

diff --git a/pkg/routingkey/routing_key_test.go b/pkg/routingkey/routing_key_test.go
@@ -27,6 +27,7 @@ import (
 )
 
 func TestRoutingKey(t *testing.T) {
+	t.Parallel()
 	type data struct {
 		values typedef.Values
 		want   []byte
@@ -462,8 +463,10 @@ func TestRoutingKey(t *testing.T) {
 		},
 	}
 
-	for name, test := range tests {
+	for name := range tests {
+		test := tests[name]
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
 			for _, d := range test.data {
 				result, err := rkc.CreateRoutingKey(test.table, d.values)
 				if err != nil {

diff --git a/pkg/stop/flag_test.go b/pkg/stop/flag_test.go
@@ -29,6 +29,7 @@ import (
 )
 
 func TestHardStop(t *testing.T) {
+	t.Parallel()
 	testFlag, ctx, workersDone := initVars()
 	workers := 30
 
@@ -39,6 +40,7 @@ func TestHardStop(t *testing.T) {
 }
 
 func TestSoftStop(t *testing.T) {
+	t.Parallel()
 	testFlag, ctx, workersDone := initVars()
 	workers := 30
 
@@ -49,6 +51,7 @@ func TestSoftStop(t *testing.T) {
 }
 
 func TestSoftOrHardStop(t *testing.T) {
+	t.Parallel()
 	testFlag, ctx, workersDone := initVars()
 	workers := 30
 

diff --git a/pkg/tableopts/options_test.go b/pkg/tableopts/options_test.go
@@ -21,6 +21,8 @@ import (
 )
 
 func TestToCQL(t *testing.T) {
+	t.Parallel()
+
 	tests := map[string]struct {
 		rs   string
 		want string
@@ -60,6 +62,7 @@ func TestToCQL(t *testing.T) {
 	}
 	for name, test := range tests {
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
 			if o, err := tableopts.FromCQL(test.rs); err != nil {
 				t.Error(err)
 			} else {

diff --git a/pkg/typedef/columns_test.go b/pkg/typedef/columns_test.go
@@ -109,6 +109,8 @@ func TestColumnMarshalUnmarshal(t *testing.T) {
 }
 
 func TestMarshalUnmarshal(t *testing.T) {
+	t.Parallel()
+
 	s1 := getTestSchema()
 
 	opts := cmp.Options{
@@ -132,6 +134,8 @@ func TestMarshalUnmarshal(t *testing.T) {
 }
 
 func TestPrimitives(t *testing.T) {
+	t.Parallel()
+
 	sc := &typedef.SchemaConfig{
 		MaxPartitionKeys:  3,
 		MinPartitionKeys:  2,
@@ -201,6 +205,8 @@ func TestPrimitives(t *testing.T) {
 }
 
 func TestValidColumnsForDelete(t *testing.T) {
+	t.Parallel()
+
 	s1 := getTestSchema()
 	expected := typedef.Columns{
 		s1.Tables[0].Columns[2],

diff --git a/pkg/typedef/schema_test.go b/pkg/typedef/schema_test.go
@@ -22,6 +22,8 @@ import (
 )
 
 func TestSchemaConfigValidate(t *testing.T) {
+	t.Parallel()
+
 	tests := map[string]struct {
 		config *SchemaConfig
 		want   error
@@ -88,6 +90,7 @@ func TestSchemaConfigValidate(t *testing.T) {
 	cmp.AllowUnexported()
 	for name, test := range tests {
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
 			got := test.config.Valid()
 			//nolint:errorlint
 			if got != test.want {

diff --git a/pkg/typedef/typedef_test.go b/pkg/typedef/typedef_test.go
@@ -21,6 +21,8 @@ import (
 )
 
 func TestValues(t *testing.T) {
+	t.Parallel()
+
 	tmp := make(Values, 0, 10)
 	expected := Values{1, 2, 3, 4, 5, 6, 7}
 	expected2 := Values{1, 2, 3, 4, 5, 6, 7, 8, 9}

diff --git a/pkg/typedef/types_test.go b/pkg/typedef/types_test.go
@@ -214,6 +214,8 @@ var prettytests = []struct {
 }
 
 func TestCQLPretty(t *testing.T) {
+	t.Parallel()
+
 	for _, p := range prettytests {
 		result, _ := p.typ.CQLPretty(p.query, p.values)
 		if result != p.expected {

diff --git a/pkg/utils/utils_test.go b/pkg/utils/utils_test.go
@@ -38,6 +38,8 @@ func BenchmarkUtilsRandString1000(t *testing.B) {
 }
 
 func TestRandString(t *testing.T) {
+	t.Parallel()
+
 	for _, ln := range []int{1, 3, 5, 16, 45, 100, 1000} {
 		out := utils.RandString(rnd, ln)
 		if len(out) != ln {