cassandra/cluster.py: use raw string when appropriate #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python complains at seeing ```py re.compile(r'^\s*BEGIN\s+[a-zA-Z]*\s*BATCH', re.UNICODE) ``` ``` <>:1: SyntaxWarning: invalid escape sequence '\s' ``` but the interpreter continues on, and take "\s" as it is without escaping it. still, it's not a valid string literal. because "\s" is not an escape sequence, while "\\s" is, but we don't have to escape "\" here, we can just use the raw string. simpler this way. in this change, we trade the invalid escape sequence with a raw string to silence this warning. Signed-off-by: Kefu Chai <[email protected]>
|
@Lorak-mmk hi Karol, could you help review this change? |
|
it's funny, I've run into this today (but didn't had time to chase it), thanks @tchaikov |
|
@fruch hi Israel, could you help merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python complains at seeing
but the interpreter continues on, and take "\s" as it is without escaping it. still, it's not a valid string literal.
because "\s" is not an escape sequence, while "\s" is, but we don't have to escape "" here, we can just use the raw string. simpler this way.
in this change, we trade the invalid escape sequence with a raw string to silence this warning.