Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dk/schema query increased timeouts #1172

Closed
wants to merge 12 commits into from

Conversation

dkropachev
Copy link
Collaborator

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

wprzytula and others added 9 commits January 16, 2025 15:02
It's in legacy serialization testing code, so it's going to be removed
soon anyway.

(cherry picked from commit 0eb98bc)
The test asserts that for ScyllaDB the timeout is enforced (if set) and
for Cassandra is always ignored, in the following cases:
- when explicitly disabled (no custom timeout follows),
- when explicitly set to some (only set for ScyllaDB),
The timeout is now stored in SessionConfig and passed down to the
MetadataReader, which sets up all its `ControlConnection`s with that
timeout.
The tests asserts that for ScyllaDB the timeout is enforced (if set) and
for Cassandra is always ignored, in the following cases:
- when explicitly disabled (no custom timeout follows),
- when explicitly set to some (only set for ScyllaDB),
- when left as implicit default (only set to ScyllaDB).
@dkropachev dkropachev changed the base branch from main to branch-0.15.x January 18, 2025 01:46
@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Jan 18, 2025
Copy link

github-actions bot commented Jan 18, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 90b9726

@github-actions github-actions bot removed the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Jan 18, 2025
@dkropachev dkropachev closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants