-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of custom scylla images #1173
Conversation
|
@wprzytula and probably you will need to backport it to scylladb:branch-0.15.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the checklist: a convention we use is to:
- Check the items that apply and were done
- Cross-out items that are not applicable (
~~
) - Leave unmarked the items that were not done for some reason.
So if the PR doesn't change the documentation (because it has not reason to), then please make it unmarked and crossed out.
This lets reviewers to know if something is not done on purpose, or because it is not applicable.
The changes themselves look fine (apart from some grammar issues in the commit messages).
No need to have special image for it, we can provide authenticator via cli
No need to keep this image, we can build it on fly
c3e0d26
to
188964e
Compare
Done, please take a look. |
Stop using custom images.
We used to use
scylladb/scylla-passauth
andscylladb/scylla-tls
in our pipeline.They were based on old scylla and has minimal config changes on them.
This PR removes them, to eleviate burdain to keep them updated.
Instead it makes them build on fly or just patch config via docker image cli.
Pre-review checklist
I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/
.I added appropriateFixes:
annotations to PR description.