Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of custom scylla images #1173

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Get rid of custom scylla images #1173

merged 2 commits into from
Jan 20, 2025

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Jan 18, 2025

Stop using custom images.

We used to use scylladb/scylla-passauth and scylladb/scylla-tls in our pipeline.
They were based on old scylla and has minimal config changes on them.
This PR removes them, to eleviate burdain to keep them updated.
Instead it makes them build on fly or just patch config via docker image cli.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

github-actions bot commented Jan 18, 2025

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 188964e

@dkropachev dkropachev marked this pull request as ready for review January 18, 2025 04:31
@dkropachev
Copy link
Collaborator Author

@wprzytula and probably you will need to backport it to scylladb:branch-0.15.x

Copy link
Collaborator

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the checklist: a convention we use is to:

  • Check the items that apply and were done
  • Cross-out items that are not applicable (~~)
  • Leave unmarked the items that were not done for some reason.

So if the PR doesn't change the documentation (because it has not reason to), then please make it unmarked and crossed out.

This lets reviewers to know if something is not done on purpose, or because it is not applicable.

The changes themselves look fine (apart from some grammar issues in the commit messages).

@dkropachev dkropachev changed the title Fix scylla images Get rid of custom scylla images Jan 20, 2025
No need to have special image for it, we can provide authenticator via cli
No need to keep this image, we can build it on fly
@dkropachev dkropachev force-pushed the dk/fix-scylla-images branch from c3e0d26 to 188964e Compare January 20, 2025 15:13
@dkropachev
Copy link
Collaborator Author

Regarding the checklist: a convention we use is to:

  • Check the items that apply and were done
  • Cross-out items that are not applicable (~~)
  • Leave unmarked the items that were not done for some reason.

So if the PR doesn't change the documentation (because it has not reason to), then please make it unmarked and crossed out.

This lets reviewers to know if something is not done on purpose, or because it is not applicable.

The changes themselves look fine (apart from some grammar issues in the commit messages).

Done, please take a look.

@dkropachev dkropachev merged commit 1439574 into main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants