-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: adjust ShardingError #1181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code more rusty and leverages the type system. Also, it extracts the constants for shared use in the next commit.
I added a new error variant to distinguish between a scenario where we (most likely) connect to Cassandra cluster (all params missing) and where Scylla has a bug (some params are present, some not).
muzarski
force-pushed
the
sharding-error
branch
from
January 27, 2025 17:59
4c7fc3c
to
52061f3
Compare
github-actions
bot
added
the
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
label
Jan 27, 2025
See the following report for details: cargo semver-checks output
|
muzarski
force-pushed
the
sharding-error
branch
from
January 27, 2025 18:09
52061f3
to
8f71461
Compare
wprzytula
requested changes
Jan 27, 2025
Lorak-mmk
previously approved these changes
Jan 28, 2025
I chose INFO log level in case ALL parameters are missing (no sharding info provided). ERROR otherwise - in case there was some failure in parsing the sharding info.
This error type is used only internally. The `ShardInfo` struct is pub(crate) as well.
muzarski
force-pushed
the
sharding-error
branch
from
January 28, 2025 12:18
8f71461
to
44cae1f
Compare
Lorak-mmk
approved these changes
Jan 28, 2025
wprzytula
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API-stability
Part of the effort to stabilize the API
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1170
The only breaking change in this PR is unpubbing
ShardingError
. Remaining commits adjust the internal usages of this error - for example logging in case parsing of sharding info fails.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have adjusted the documentation in./docs/source/
.Fixes:
annotations to PR description.