Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce function to deserialize CloudConfig from Read #1183

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RomanHargrave
Copy link

@RomanHargrave RomanHargrave commented Jan 29, 2025

In many cases, it may be desirable to store the contents of the cloud configuration YAML outside of the local filesystem. In order to support this, all that should be necessary is to allow for CloudConfig to be deserialized from a Read, rather than a file located at some path, and to allow for the CloudSessionBuilder to be constructed from an existing CloudConfig.

I considered a CloudSessionBuilder constructor which accepted a Read, but settled on accepting CloudConfig instead as this seemed more logical by a small margin. I would ultimately be comfortable with either implementation, depending on maintainer preference.

Draft because I need to address some of the checklist items.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@RomanHargrave RomanHargrave changed the title Support for cloud configuration stored in places other than the local filesystem Public interface to deserialize CloudConfiguration from Read Jan 29, 2025
@RomanHargrave RomanHargrave changed the title Public interface to deserialize CloudConfiguration from Read Introduce function to deserialize CloudConfiguration from Read Jan 29, 2025
@RomanHargrave RomanHargrave changed the title Introduce function to deserialize CloudConfiguration from Read Introduce function to deserialize CloudConfig from Read Jan 29, 2025
Copy link

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: 6b4bb35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant