Introduce function to deserialize CloudConfig from Read #1183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, it may be desirable to store the contents of the cloud configuration YAML outside of the local filesystem. In order to support this, all that should be necessary is to allow for
CloudConfig
to be deserialized from aRead
, rather than a file located at some path, and to allow for theCloudSessionBuilder
to be constructed from an existingCloudConfig
.I considered a
CloudSessionBuilder
constructor which accepted aRead
, but settled on acceptingCloudConfig
instead as this seemed more logical by a small margin. I would ultimately be comfortable with either implementation, depending on maintainer preference.Draft because I need to address some of the checklist items.
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.