Skip to content

Commit

Permalink
github/workflow: do not override <clang++,23,release>
Browse files Browse the repository at this point in the history
before this change, we

* override the combination of <clang++,23,release>
  by adding settings to build with dpdk enabled,
* override the combination of <clang++,23,debug>
  by adding settings to build with C++20 moduels
  enabled.

but what we intended was to add two additional
builds.

so, in this change, we preserve the existing
combinations of <clang++,23,release> and
<clang++,23,debug> by includeing all the
combinations explicitly, and add the builds
with dpdk and C++20 modules. also the matrix
does not allows one to add extra settings without
overriding an existing combination.
see also https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

also remove the confusing comment

based on the feedback of reviewer,

> the phrase "only build this combination when dpdk is enable" confusing
> - the phrase "in addition to the above" says the opposite, that we did
> build this combination without dpdk but now we'll build it again with
> dpdk.

Signed-off-by: Kefu Chai <[email protected]>

Closes #2227
  • Loading branch information
tchaikov authored and nyh committed May 8, 2024
1 parent a9c89e7 commit d6d4784
Showing 1 changed file with 36 additions and 8 deletions.
44 changes: 36 additions & 8 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,47 @@ jobs:
standard: [20, 23]
mode: [dev, debug, release]
include:
# in addition to the above combinations, add a combination to build with
# dpdk. but only build this combination when dpdk is enabled, so we don't
# double the size of the test matrix, and can at least test the build
# with dpdk enabled.
- compiler: clang++-18
standard: 20
mode: dev
- compiler: clang++-18
standard: 20
mode: debug
- compiler: clang++-18
standard: 20
mode: release
- compiler: clang++-18
standard: 23
mode: dev
- compiler: clang++-18
standard: 23
mode: debug
- compiler: clang++-18
standard: 23
mode: release
- compiler: gcc-13
standard: 20
mode: dev
- compiler: gcc-13
standard: 20
mode: debug
- compiler: gcc-13
standard: 20
mode: release
- compiler: gcc-13
standard: 23
mode: dev
- compiler: gcc-13
standard: 23
mode: debug
- compiler: gcc-13
standard: 23
mode: release
- compiler: clang++-18
standard: 23
mode: release
cooks: --cook dpdk
enables: --enable-dpdk
# in addition to the above combinations, add a combination to build with
# C++20 modules. but only build this combination with C++20 modules enabled,
# so we don't double the size of the test matrix, and can at least test the
# build with C++20 modules enabled.
- compiler: clang++-18
standard: 23
mode: debug
Expand Down

0 comments on commit d6d4784

Please sign in to comment.