treewide: do not check for SEASTAR_COROUTINES_ENABLED #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we've dropped the support for C++17, and we even started using C++20 coroutines in 1d56a1d unconditionally in the implementation of Seastar, there is no need to check the support of coroutine anymore. so, in this change, we * stop check and define SEASTAR_COROUTINES_ENABLED * do not check SEASTAR_COROUTINES_ENABLED * drop the code for handling the case where SEASTAR_COROUTINES_ENABLED is not defined. Signed-off-by: Kefu Chai <[email protected]>
nyh
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we've dropped the support for C++17, and we even started using C++20 coroutines in 1d56a1d unconditionally in the implementation of Seastar, there is no need to check the support of coroutine anymore.
so, in this change, we