tests: merge test_metrics.py into prometheus_test.py #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
prometheus-test
branch
3 times, most recently
from
3083a2d to
903e2b6
Compare
in order to reduce the replicated code, this change adds a test to prometheus_test.py, to verify the metrics without aggregations. since we already have the coverage for this feature, let's drop it from test_metrics.py. Signed-off-by: Kefu Chai <[email protected]>
in this change, we * add a test for testing protobuf support in prometheus_test.py * drop test_metrics.py, as all the tests in it have been moved into prometheus_test.py Signed-off-by: Kefu Chai <[email protected]>
|
@amnonh hello Amnon, ping? |
|
@amnonh hey Amnon, ping? |
|
@tchaikov I was on vacation, I'll take a look |
|
Thank you Amnon! |
|
In general, it makes sense; that was my original comment when you added prometheus_test.py; why have two files for the same purpose when we can have one? I haven't tested the code but I assume it works |
|
Amnon, thank you for your review and approval. |
|
@scylladb/seastar-maint hello maintainers, could you help merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this series, we move all tests in
test_metrics.pyintoprometheus_test.pyto drop the repeating code.